Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support links of the form [[Path/To/Link]]. #1925

Closed
hameerabbasi opened this issue May 5, 2021 · 4 comments
Closed

[FEATURE] Support links of the form [[Path/To/Link]]. #1925

hameerabbasi opened this issue May 5, 2021 · 4 comments
Labels
stale This label indicates that this issue might be automatically closed soon.

Comments

@hameerabbasi
Copy link

Description

Allow links from the root of the Zettelkasten.

Proposed Changes

If I click on a link similar to [[Path/To/File]], it should try to find it as a relative path in ., ./.., ./../.. iteratively until we can't find anything in the root of the Zettelkasten in this way.

Caveats

Links no longer valid before may become valid. But that's kind of the point, no? 😉

Additional Information

Obsidian provides this feature, and I'm trying to switch. I have a lot of files, and wouldn't like to change all the links. Additionally, I find it better to order things hierarchically in my head, so this is helpful.

I'm perfectly willing to implement this, I found, e.g. render-links.js and make-valid-uri.js as two possible places. I'm willing to make a PR and would appreciate some guidance on what parts of the code to touch.

@boring-cyborg
Copy link

boring-cyborg bot commented May 5, 2021

Thanks so much for opening up your first issue here on the repository! 🎉 We would like to warmly welcome you to the community behind the app! ☺️ We'll check in soon and have a look at your issue. In the meantime, you can check your issue and make sure it aligns with our contribution guidelines! Here's the comprehensive list:

Enhancements

An enhancement takes a feature and improves or alters its behaviour. Please make sure to argue how your proposition will aid non-technical text workers, and why it can't be emulated easily with other features or apps!

Feature requests

Feature requests introduce whole new features into the app. This requires a lot of work, so these might be turned down if the implementation costs supersede the benefits we expect to see from implementing it. Please do not be disappointed if that happens. It likely has nothing to do with your great request but simply with us and our missing resources!
You can of course always ask someone to implement this feature, because a PR with a working new feature has much higher chances of being merged! :)

Bug reports

Please note that one of the main reasons for why bug reports cannot be addressed is that there's not enough information for us to find and fix the bug you describe, so make sure you try to pinpoint the bug as close as possible.
The ideal bug report for us has two qualities:

  1. The bug is always reproducible, at least within a certain context. 2. We know exactly what specifically goes wrong, and there is consensus on
    what should happen instead.

Please note that if you encounter behaviour that does not align with your expectations of what would happen, this might as well be simply intended behaviour and we need to simply clarify why the behaviour is the way it is. This is not to be considered a bug and such issues may be closed! Suggest an enhancement instead!
But now, have a great day and thank you again!

@nathanlesage
Copy link
Member

I'm sympathetic to this, given that it's not just implemented by Obsidian. I want to keep features out of Zettlr that only very few different apps understand, but everything that is en route to becoming "common" should be, so if that's one thing, feel free to go for it!

@stale
Copy link

stale bot commented Jul 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale This label indicates that this issue might be automatically closed soon. label Jul 11, 2021
@stale
Copy link

stale bot commented Jul 20, 2021

This issue has been automatically closed due to inactivity. If you believe that this issue is relevant for many users and should not be closed, feel free to comment so that the admins will be notified.

@stale stale bot closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This label indicates that this issue might be automatically closed soon.
Projects
None yet
Development

No branches or pull requests

2 participants