Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning Address: handle addresses hosted on Tor #1349

Merged
merged 11 commits into from Apr 12, 2023

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Mar 4, 2023

Description

Prompted by openoms. Needs thorough testing.

  • LN Address: oniontip@7tpv3ynajkv6cdocmzitcd4z3xrstp3ic6xtv5om3dc2ned3fffll5qd.onion

    • send field
    • QR code
      qrcode
  • LNURL-pay 1
    lnurl1xa68qa3n09hxz6ntwcmxxer0vdkh56t5vdjrg73n0pe8xarsxd5kxdncw3mr2mmdxdjxxvnwv4jrxenxvekxcdt3vshx7mnfdahz7tnhv4kxctttdehhwm30d3h82unvwqhk7mnfdah8g6tsn474jp

    • send field
    • QR code
      qrcode(1)
  • LNURL-pay 2 lnurl1dp68gup69uhnwarswcehjmnpdf4hvdnrv3hkxmt6d96xxep50gehsunnw3crx6trxeu8ga34daknxerrxfhx2epnvenxvmrvx4ckgtn0de5k7m309emk2mrv944kummhdchkcmn4wfk8qtm0de5k7mn5d9cq045u4j

    • send field
    • QR code
      qrcode(2)

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis force-pushed the ln-address-tor branch 2 times, most recently from b4dfd97 to 55f2393 Compare March 4, 2023 23:05
@kaloudis kaloudis marked this pull request as ready for review April 8, 2023 19:16
@kaloudis kaloudis added this to the v0.7.5 milestone Apr 8, 2023
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 531faff into ZeusLN:master Apr 12, 2023
3 checks passed
@kaloudis kaloudis deleted the ln-address-tor branch April 12, 2023 18:52
@theborakompanioni
Copy link

Does this work for anyone? I am getting Error: SOCKS: Connection refused on v0.7.5

@theborakompanioni
Copy link

Does this work for anyone? I am getting Error: SOCKS: Connection refused on v0.7.5

I'm sorry to bother anyone with this, but it would be great if it worked as advertised : D
Any inputs on this one @kaloudis? Should I open a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants