Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LND v0.17.0 + Simple Taproot Channels, UTXO selection, send max for channel opens #1624

Merged
merged 8 commits into from Aug 28, 2023

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Aug 25, 2023

Description

Relates to issue: ZEUS-1609

This PR bumps the embedded LND node to version v0.17.0-beta.rc1. It includes the following additions

  • Displays commitment type on the Channel view
  • Adds the ability to open up Simple Taproot Channels in LND v0.17.0+
  • Reintroduces UTXO selection for LND channel opens
  • Adds a new send max or Use all possible funds toggle on the OpenChannel view
  • Breaks out some new settings into an Advanced Settings collapsed section on the OpenChannel view
  • View will scroll to the top on an Open Channel or Connect Peer event on the OpenChannel view

Some screenshots:

Simulator Screen Shot - iPhone 14 - 2023-08-26 at 12 33 49
Simulator Screen Shot - iPhone 14 - 2023-08-26 at 12 33 44
Simulator Screen Shot - iPhone 14 - 2023-08-26 at 12 33 41
Simulator Screen Shot - iPhone 14 - 2023-08-26 at 01 10 51

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis force-pushed the lnd-v0.17.0 branch 2 times, most recently from eaca527 to 0f69131 Compare August 26, 2023 05:03
@kaloudis kaloudis changed the title LND v0.17.0 LND v0.17.0 + Simple Taproot Channels Aug 26, 2023
@kaloudis kaloudis changed the title LND v0.17.0 + Simple Taproot Channels LND v0.17.0 + Simple Taproot Channels, UTXO selection, send max for channel opens Aug 26, 2023
@kaloudis kaloudis marked this pull request as ready for review August 26, 2023 16:20
@kaloudis kaloudis merged commit 8b39ac2 into ZeusLN:master Aug 28, 2023
3 checks passed
@kaloudis kaloudis deleted the lnd-v0.17.0 branch August 28, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant