Standalone POS #1722

Talej · 2023-10-02T22:59:38Z

Description

Implements standalone POS functionality.

Changes the enable square POS setting to allow enable Square or Standalone mode.
Under POS settings adds support for managing categories and products.
Products can be priced in sats or fiat.
Adds a standalone POS order creation screen and allows invoicing through the existing payment flow.

** Note: ** I haven't yet tested this on an Android device. Currently without a working device

This pull request is categorized as a:

Checklist

I’ve run yarn run tsc and made sure my code compiles correctly
I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
I’ve run yarn run prettier and made sure my code is formatted correctly
I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

No, I’m a fool
Yes
N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

Android
iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

Locales

I’ve added new locale text that requires translations
I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

Contributors will need to run yarn after this PR is merged in
3rd party dependencies have been modified:
- verify that package.json and yarn.lock have been properly updated
- verify that dependencies are installed for both iOS and Android platforms

Other:

Changes were made that require an update to the README
Changes were made that require an update to onboarding

shubhamkmr04

Getting this warning as soon as we open the POS settings

shubhamkmr04

Screen.Recording.2023-10-12.at.6.59.19.PM.mov

Not able to change the unit to 'sats'

shubhamkmr04

If the Category gets deleted, the product belonging to that Category should also be deleted.

shubhamkmr04

Screen.Recording.2023-10-12.at.10.08.11.PM.mov

We should have a counter here on this view to know how many products we have selected so far and maybe a way to remove it, too.
@kaloudis, what do you think about this?

shubhamkmr04

Screen.Recording.2023-10-12.at.10.13.21.PM.mov

So we add our product to checkout and pay, then delete it from the settings, come to the homepage, and still can see our checked-out price belonging to our deleted product.

kaloudis · 2023-10-12T16:54:01Z

Screen.Recording.2023-10-12.at.10.08.11.PM.mov

We should have a counter here on this view to know how many products we have selected so far and maybe a way to remove it, too. @kaloudis, what do you think about this?

+1 on having a counter

kaloudis · 2023-10-12T16:54:19Z

Screen.Recording.2023-10-12.at.10.13.21.PM.mov

So we add our product to checkout and pay, then delete it from the settings, come to the homepage, and still can see our checked-out price belonging to our deleted product.

Deleting a product should probably trigger a cart clear

Talej · 2023-10-13T03:52:12Z

Screen.Recording.2023-10-12.at.10.08.11.PM.mov
We should have a counter here on this view to know how many products we have selected so far and maybe a way to remove it, too. @kaloudis, what do you think about this?

I have added an item counter in the "Charge" button.

Other thing I could think to do is add - (n) + in each of the product components. Might not be super user friendly though IMO.

Talej · 2023-10-13T03:55:42Z

Getting this warning as soon as we open the POS settings

This one would've already been in there previously but I have sorted it out by dropping the FlatList

Talej · 2023-10-13T03:56:14Z

All of these items and a couple more things I found should be sorted out now.

shubhamkmr04 · 2023-10-13T07:35:34Z

Screen.Recording.2023-10-12.at.10.08.11.PM.mov
We should have a counter here on this view to know how many products we have selected so far and maybe a way to remove it, too. @kaloudis, what do you think about this?

I have added an item counter in the "Charge" button.

Other thing I could think to do is add - (n) + in each of the product components. Might not be super user friendly though IMO.

Yup, I understood. @kaloudis, should we do that, or the overall counter would be fine

shubhamkmr04

Should we also remove open orders of deleted products?🤔

shubhamkmr04

Screen.Recording.2023-10-13.at.1.21.27.PM.mov

We cannot save a product to the first category in the list; it goes into the uncategorized products. It only happens in the android.

shubhamkmr04

On the ProductDetails and ProductCategoryDetails views, In the delete button, we should have our props containerStyle and titleStyle set to themeColor('delete') to maintain consistency with other views.

shubhamkmr04 · 2023-10-13T08:16:43Z

Screen.Recording.2023-10-12.at.10.13.21.PM.mov
So we add our product to checkout and pay, then delete it from the settings, come to the homepage, and still can see our checked-out price belonging to our deleted product.

Deleting a product should probably trigger a cart clear

Would it be better to subtract that deleted product's price instead of clearing the whole cart?

shubhamkmr04

Screen.Recording.2023-10-13.at.1.55.07.PM.mov

Products belonging to the deleted category still exist. Only the last saved product gets deleted.

Talej · 2023-10-21T04:10:15Z

Screen.Recording.2023-10-12.at.10.13.21.PM.mov
So we add our product to checkout and pay, then delete it from the settings, come to the homepage, and still can see our checked-out price belonging to our deleted product.

Deleting a product should probably trigger a cart clear

Would it be better to subtract that deleted product's price instead of clearing the whole cart?

I think it would be a pretty rare condition that the user is editing/deleting products at the same time as actually making sales so I feel like just clearing the whole cart should be sufficient. What do you think?

Talej · 2023-10-21T05:39:14Z

Should we also remove open orders of deleted products?🤔

I feel like maybe this would lead to confusion and it should probably be left to the user to either hide/cancel the order or create a new one.

Talej · 2023-10-21T05:43:09Z

Fixed category delete issue with products
Fixed issue with selecting category for product on android
Updated styling for delete buttons

Ready for another round!

kaloudis · 2023-10-21T18:42:26Z

Screen.Recording.2023-10-12.at.10.13.21.PM.mov
So we add our product to checkout and pay, then delete it from the settings, come to the homepage, and still can see our checked-out price belonging to our deleted product.

Deleting a product should probably trigger a cart clear

Would it be better to subtract that deleted product's price instead of clearing the whole cart?

I think it would be a pretty rare condition that the user is editing/deleting products at the same time as actually making sales so I feel like just clearing the whole cart should be sufficient. What do you think?

This should suffice

kaloudis · 2023-10-21T18:43:09Z

Should we also remove open orders of deleted products?🤔

I feel like maybe this would lead to confusion and it should probably be left to the user to either hide/cancel the order or create a new one.

can go either way here. I don't think this is a deal breaker either way. maybe something that gets iterated on

shubhamkmr04

Screen.Recording.2023-10-23.at.4.25.41.PM.mov

The screen returns to the top when I select any product, which might affect the user's experience as they would have to scroll down again and again if we have so many products listed.

shubhamkmr04 · 2023-10-23T11:05:40Z

views/POS/ProductDetails.tsx

+                    }
+                ];
+                categoryOptions = categoryOptions.concat(...mappedCategories);
+                console.log('options', categoryOptions);


Do we need this console, or was it just for debugging?

Was just for debugging. Have removed now

Talej · 2023-10-27T08:30:18Z

Screen.Recording.2023-10-23.at.4.25.41.PM.mov
The screen returns to the top when I select any product, which might affect the user's experience as they would have to scroll down again and again if we have so many products listed.

Having the Charge button up in the Tab Navigator was triggering re-render on every touch. I have restructured it so that doesn't happen any more.

Unfortunately means that I can't use the Tab Navigator space now so we've lost a bit of screen real estate

shubhamkmr04 · 2023-10-27T13:54:27Z

@kaloudis, does the button look good in here?

shubhamkmr04

Screen.Recording.2023-10-27.at.7.24.49.PM.mov

The amount is stuck on the price of first product I selected.

Talej · 2023-10-28T01:55:13Z

Screen.Recording.2023-10-27.at.7.24.49.PM.mov
The amount is stuck on the price of first product I selected.

Not sure how I missed that one. Nice catch. Fixed now!

…egory

kaloudis · 2023-12-19T00:43:33Z

hitting an issue here where the AmountInput component is pre-filled with value undefined and I cannot change the amount

Talej · 2023-12-19T00:44:57Z

hitting an issue here where the `AmountInput` component is pre-filled with value `undefined` and I cannot change the amount

creating a new product or editing an existing?

kaloudis · 2023-12-19T00:45:41Z

hitting an issue here where the `AmountInput` component is pre-filled with value `undefined` and I cannot change the amount

creating a new product or editing an existing?

create a new product

kaloudis · 2023-12-19T20:47:37Z

Looking good now! I've also double checked the structure to ensure that fiat prices are recorded properly.

shubhamkmr04

The amount is prefilled with 0 that we can't remove

Talej · 2023-12-20T07:05:44Z

The amount is prefilled with 0 that we can't remove

Fixed

shubhamkmr04 · 2023-12-20T08:22:42Z

Looks fine now.

kaloudis · 2023-12-22T02:35:06Z

Code looks good. A few things missing though:

Ability (or option) to go to order overview before generating invoice (allows user to set tip on this screen and see the total w/ tax) [you can go to this view if you don't pay and click on an order under the Open tab)
Ability to set tax %
Ability to disable tips

LMK what you think @Talej. Open to shipping it in beta1 as is and breaking up follow up work in other PRs.

kaloudis · 2023-12-22T02:41:51Z

nit: let's also put the Standalone option above Square in the selection menu

kaloudis · 2023-12-26T17:15:45Z

I've made the suggested changes myself to the PR:

Standalone placed above Square in the mode selection dropdown
Charging an order now takes you to an itemized breakdown instead of directly to the invoice (let's give some thought into if we want to make this configurable)
Disable tip and conf preferences are now displayed when on the POS settings when in Standalone mode
New tax percentage setting added to POS settings when in Standalone mode

I also noticed a bug with how itemized products were displayed on the Order view: amount displayed was 100x lower. Change can be found here: ad49272#diff-7ffe38a0457034ead72df14de5a05813a6c8a8945e64551040568d72e81a7d5eR330 Just need a sanity check here, but it appears to be rendering properly now.

Talej · 2023-12-27T21:55:00Z

I've made the suggested changes myself to the PR:

Standalone placed above Square in the mode selection dropdown

Charging an order now takes you to an itemized breakdown instead of directly to the invoice (let's give some thought into if we want to make this configurable)

Disable tip and conf preferences are now displayed when on the POS settings when in Standalone mode

New tax percentage setting added to POS settings when in Standalone mode

I also noticed a bug with how itemized products were displayed on the Order view: amount displayed was 100x lower. Change can be found here: ad49272#diff-7ffe38a0457034ead72df14de5a05813a6c8a8945e64551040568d72e81a7d5eR330 Just need a sanity check here, but it appears to be rendering properly now.

This all checks out and looks okay to me!

shubhamkmr04

tACK

Talej changed the base branch from pos to master October 2, 2023 23:17

kaloudis added this to the v0.8.1 milestone Oct 12, 2023

kaloudis requested a review from shubhamkmr04 October 12, 2023 04:59

shubhamkmr04 reviewed Oct 12, 2023

View reviewed changes

shubhamkmr04 reviewed Oct 13, 2023

View reviewed changes

shubhamkmr04 reviewed Oct 23, 2023

View reviewed changes

shubhamkmr04 reviewed Oct 27, 2023

View reviewed changes

Talej added 10 commits December 19, 2023 11:30

review feedback changes

52c2b27

Feedback round 2

c4128c9

Fixed re-render issue and removed debug

5109cb1

Fixed issue with price not updating

8cb0756

order sorting, loading current order, section background, editing cat…

a85449c

…egory

rebase and feedback changes

5133acc

fixed lint errors

eac5bfe

Changed product details to use AmountInput

fe97bdb

Removed POS menu easter egg

05a6a8f

removed unused PRICED_IN_KEYS

99f0c2b

Talej force-pushed the pos branch from 9074ad3 to 99f0c2b Compare December 19, 2023 00:38

Fixed undefined error when no categories exist

01d7d77

shubhamkmr04 reviewed Dec 20, 2023

View reviewed changes

fixed problem with 0 amount

5718eb7

kaloudis added 4 commits December 26, 2023 11:11

Standalone POS: take user to itemized list on charge

30e28b5

Standalone POS settings: add disable tips and conf preference

146f23c

Standalone POS: add tax percentage setting

ad49272

Settings: Point of Sale: put Standalone option above Square

d054810

shubhamkmr04 reviewed Dec 28, 2023

View reviewed changes

kaloudis merged commit 3c5ba98 into ZeusLN:master Dec 28, 2023
3 checks passed

Standalone POS #1722

Standalone POS #1722

Conversation

Talej commented Oct 2, 2023

Description

Checklist

Testing

Locales

Third Party Dependencies and Packages

Other:

shubhamkmr04 left a comment

Choose a reason for hiding this comment

shubhamkmr04 left a comment

Choose a reason for hiding this comment

shubhamkmr04 left a comment

Choose a reason for hiding this comment

shubhamkmr04 left a comment

Choose a reason for hiding this comment

shubhamkmr04 left a comment

Choose a reason for hiding this comment

kaloudis commented Oct 12, 2023

kaloudis commented Oct 12, 2023

Talej commented Oct 13, 2023

Talej commented Oct 13, 2023

Talej commented Oct 13, 2023

shubhamkmr04 commented Oct 13, 2023

shubhamkmr04 left a comment

Choose a reason for hiding this comment

shubhamkmr04 left a comment

Choose a reason for hiding this comment

shubhamkmr04 left a comment • edited

Choose a reason for hiding this comment

shubhamkmr04 commented Oct 13, 2023

shubhamkmr04 left a comment

Choose a reason for hiding this comment

Talej commented Oct 21, 2023

Talej commented Oct 21, 2023

Talej commented Oct 21, 2023

kaloudis commented Oct 21, 2023

kaloudis commented Oct 21, 2023

shubhamkmr04 left a comment

Choose a reason for hiding this comment

shubhamkmr04 Oct 23, 2023

Choose a reason for hiding this comment

Talej Oct 27, 2023

Choose a reason for hiding this comment

Talej commented Oct 27, 2023

shubhamkmr04 commented Oct 27, 2023

shubhamkmr04 left a comment

Choose a reason for hiding this comment

Talej commented Oct 28, 2023

kaloudis commented Dec 19, 2023

Talej commented Dec 19, 2023

kaloudis commented Dec 19, 2023

kaloudis commented Dec 19, 2023

shubhamkmr04 left a comment

Choose a reason for hiding this comment

Talej commented Dec 20, 2023

shubhamkmr04 commented Dec 20, 2023

kaloudis commented Dec 22, 2023

kaloudis commented Dec 22, 2023

kaloudis commented Dec 26, 2023

Talej commented Dec 27, 2023

shubhamkmr04 left a comment

Choose a reason for hiding this comment

shubhamkmr04 left a comment •

edited