Improved UI/UX for LNDhub read-only wallets #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaloudis
reviewed
Oct 18, 2023
kaloudis
reviewed
Oct 18, 2023
| @@ -418,6 +418,7 @@ export default class LND { | |||
| supportsLnurlAuth = () => true; | |||
| supportsOnchainSends = () => true; | |||
| supportsOnchainReceiving = () => true; | |||
| supportsLightningSends = () => true; | |||
There was a problem hiding this comment.
should be able to do this for LND too as it has macaroons as well. tough to test an endpoint without sending though
There was a problem hiding this comment.
no idea how to do it... but since app behaviour is not changed by this, i think we can implement this later as well..?
kaloudis
reviewed
Oct 18, 2023
myxmaster
force-pushed
the
disable_send_for_readonly_lndhub_accounts
branch
from
0b9fe7e
to
289554d
Compare
myxmaster
force-pushed
the
disable_send_for_readonly_lndhub_accounts
branch
from
289554d
to
40a7db9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #1780.
When connected to an LNDhub read-only ("invoice") wallet, Zeus now:
This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: