Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: persistent LND service #1906

Merged
merged 8 commits into from Dec 30, 2023
Merged

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Dec 12, 2023

Description

This PR adds a persistent LND process setting for Android devices. It also adds scaffolding to add a Tor daemon for the embedded node on both Android and iOS.

h/t Hampus and Blixt for the groundwork

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis marked this pull request as draft December 12, 2023 16:08
@kaloudis kaloudis changed the title Android: New Tor implementation and persistent LND + Tor services New Tor implementation and persistent LND + Tor services Dec 12, 2023
@kaloudis kaloudis force-pushed the persistent-tor-lnd branch 5 times, most recently from ef20c6b to f4b29f4 Compare December 12, 2023 20:08
@kaloudis kaloudis added this to the v0.8.1 milestone Dec 15, 2023
@kaloudis kaloudis changed the title New Tor implementation and persistent LND + Tor services Android: persistent LND service Dec 18, 2023
@kaloudis kaloudis marked this pull request as ready for review December 18, 2023 22:21
@kaloudis kaloudis merged commit 0080364 into ZeusLN:master Dec 30, 2023
3 checks passed
@kaloudis kaloudis deleted the persistent-tor-lnd branch December 30, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant