Skip to content
This repository has been archived by the owner on Nov 15, 2020. It is now read-only.

Log format #61

Closed
iasoon opened this issue Sep 15, 2017 · 8 comments
Closed

Log format #61

iasoon opened this issue Sep 15, 2017 · 8 comments

Comments

@iasoon
Copy link
Member

iasoon commented Sep 15, 2017

Now that we should try to decide on an universal logger interface, it is important to think about the logging format that we want to support.
As usual, being more restrictive will give the framework more power, but being permissive is just, well, generally being nice.

The most important considerations, according to me™:

  • Do we force a line-based format
  • Do we force a JSON-based format
  • Do we force having a record for each turn played
@wschella
Copy link
Member

Do we want to force anything? The framework never rally handles the logs except as a blob of data. It's the visualizer which is game-specific that cares for it the most.

@iasoon
Copy link
Member Author

iasoon commented Sep 15, 2017

@wschella Don't we have to do at least a bit of introspection, for example when streaming data from the bot-driver to the visualizer? We will have to know what data constitutes a record, and which does not.

We could, of course, argue that one log call == one record, but that would be about the same as using a line-based format.
In the streaming situation, it would also be impossible to know whether a turn has passed when it is not logged. This could be very annoying in visualizing. However, one could then argue that it is the games responsibility to fix this, and log every turn if this is expected ...

@wschella
Copy link
Member

Depends on how we want to interact with the visualizer. If we want a visualizer to be able to handle a stream of data, we don't need any introspection, in the case of objects, records, entities we do.

@iasoon
Copy link
Member Author

iasoon commented Sep 15, 2017

You are right. I guess we should focus on the log as a data stream. All of the concepts building on top of that are optional, right?

@wschella
Copy link
Member

't Is

@iasoon
Copy link
Member Author

iasoon commented Sep 15, 2017

FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF

@iasoon
Copy link
Member Author

iasoon commented Sep 16, 2017

I'll leave this open for a little longer for other opinions!

@iasoon
Copy link
Member Author

iasoon commented Nov 21, 2017

Closing due to inactivity.

@iasoon iasoon closed this as completed Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants