fix：系统定时任务持久化 #275
Closed
fix：系统定时任务持久化 #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhouYixun
reviewed
Nov 23, 2022
| @@ -52,6 +55,7 @@ public class JobsServiceImpl extends SonicServiceImpl<JobsMapper, Jobs> implemen | |||
| @Transactional(rollbackFor = Exception.class) | |||
| public RespModel<String> saveJobs(Jobs jobs) throws SonicException { | |||
| jobs.setStatus(JobStatus.ENABLE); | |||
| jobs.setType("TEST_JOB"); | |||
| save(jobs); | |||
There was a problem hiding this comment.
这个“TEST_JOB”可以提取为一个final string会更优雅，然后其他地方直接引用就行了
There was a problem hiding this comment.
private List<String> typeList = Arrays.asList("cleanFile", "cleanResult", "sendDayReport", "sendWeekReport");
你这里全小写的，TEST_JOB也可以统一一下
There was a problem hiding this comment.
因为数据库有变更所以针对历史数据的处理，让用户自行处理，还是写个兼容的逻辑？
ZhouYixun
reviewed
Nov 23, 2022
| /** | ||
| * Mapper 接口 | ||
| * @author JayWenStar | ||
| */ | ||
| @Mapper | ||
| public interface JobsMapper extends BaseMapper<Jobs> { | ||
|
|
||
| @Select("select * from jobs where type = #{type}") | ||
| Jobs findByType(@Param("type") String type); | ||
| } |
There was a problem hiding this comment.
我们后面计划逐渐减少这种使用方法，建议可以直接在QuartzHandler.java 用lambdaquery直接eq type就可以了
There was a problem hiding this comment.
我把 findByType 加到 JobsService 里面吧，然后用 lambdaquery 的写法
ZhouYixun
requested changes
Nov 23, 2022
|
已优化，我重新提交一个PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在提出此拉取请求时，我确认了以下几点（保存后请点击复选框）：
填写PR内容：
1、jobs 表添加 type 字段用于区分系统/非系统定时任务，需要对原来的非系统定时任务做下处理
typeVARCHAR(20)type= 'TEST_JOB' WHEREtypeis null2、定时任务相关的接口根据
type字段进行了过滤3、系统定时任务保存到 jobs 表中，初始化系统定时任务时，从表中取 cron 表达式
4、如果表中没有系统定时任务，会初始化进去