Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested-stack sample process death state persistence might have gotten messed up with 1.5.0 #35

Closed
Zhuinden opened this issue May 6, 2017 · 5 comments
Labels

Comments

@Zhuinden
Copy link
Owner

Zhuinden commented May 6, 2017

It definitely used to work but now the viewstate seems to get cleared.

That's not good at all! The most intrusive change was switching to DefaultStateChanger, so that's the primary culprit.

Nested stacks are so hacky.

@Zhuinden Zhuinden added the bug label May 6, 2017
@Zhuinden
Copy link
Owner Author

Zhuinden commented May 6, 2017

Oh it's because the retained fragment is restored after the scopes are reset, so the backstack manager is still nulled out at the time.

I guess the navigator switch killed it just gotta switch the two lines.

@Zhuinden
Copy link
Owner Author

Zhuinden commented May 7, 2017

.... Actually, I think the PreserveTreeScopeStrategy doesn't have all the keys after process death yet... A different strategy is required that keeps track of all keys in all active stacks...

@Zhuinden
Copy link
Owner Author

......man, this is disappointing. I'll fix this when I figure it out correctly.

@Zhuinden
Copy link
Owner Author

Honestly, I should probably rewrite it.

Didn't feel like it yet. Gonna happen eventually tho.

@Zhuinden
Copy link
Owner Author

Zhuinden commented Jul 21, 2017

I'll leave this for another day, another time, another place, and another solution.

Deleted sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant