Skip to content
This repository has been archived by the owner on Oct 28, 2020. It is now read-only.

Config file #115

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Config file #115

wants to merge 13 commits into from

Conversation

ZimGil
Copy link
Owner

@ZimGil ZimGil commented Dec 3, 2018 •
edited

Configuration file added

  • All settings moved to config file [resolves Config file #114]

    Default config is set at ng-wiz-config.ts
    User can adjust config in config.json file

    config.json file is not required for the app to run, it also doesn't have to hold all configurations.

  • bin/ng-wiz changed to Typescript

    package.json adjusted to run /bin out of /dist folder

  • ng-wiz command arguments adjusted for launching browser

    The user can now override config file settings with command argument:

    -l - Launch browser
    -dl - Don't launch browser

More info

ngWizConfig()is accessable from throughout the project, both App and Server so we can use it to hold ANY configuration needed to have the user be able to adjust setting in 1 place.

We could also have a exampleConfig.json to have an example for the user on all configurations available.

@ZimGil ZimGil added enhancement New feature or request organize Make sure everything is in the right place labels Dec 3, 2018
@ZimGil ZimGil self-assigned this Dec 3, 2018
@ZimGil ZimGil requested a review from ortichon December 3, 2018 18:37
@ZimGil
Copy link
Owner Author

ZimGil commented Dec 4, 2018

ngWizConfig()is accessable from throughout the project, both App and Server so we can use it to hold ANY configuration needed to have the user be able to adjust setting in 1 place.

Actually There's a problem when importing the config to the client side because of path and fs so I guess the best way will be to get the config to the client through the server

@ZimGil
Copy link
Owner Author

ZimGil commented Dec 4, 2018

Client Configurations

  • Added some client configurations to the config

    ngServePort - Default port for ng serve commands.
    ngServeLaunchBrowser - Default configuration regarding whether or not to launch the browser when running ng serve.

  • Server serve config

    Server now capable of sending config file upon request using get('/config')

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ortichon ortichon Awaiting requested review from ortichon

At least 1 approving review is required to merge this pull request.

Assignees

@ZimGil ZimGil

Labels
enhancement New feature or request organize Make sure everything is in the right place
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config file
1 participant
@ZimGil