Skip to content
This repository has been archived by the owner on Oct 28, 2020. It is now read-only.

check ng new error like angular cli #64

Open
ZimGil opened this issue Oct 21, 2018 · 1 comment
Open

check ng new error like angular cli #64

ZimGil opened this issue Oct 21, 2018 · 1 comment
Assignees
Labels
future This should be solved later on server Vulnerability

Comments

@ZimGil
Copy link
Owner

ZimGil commented Oct 21, 2018

we should not count on string compares while checking for angular project directories, we should try to make the same checks made by angular cli

this issue come to fix a vulnerability created on #63

@ZimGil ZimGil added server future This should be solved later on Vulnerability labels Oct 21, 2018
@ZimGil ZimGil self-assigned this Oct 21, 2018
@ZimGil
Copy link
Owner Author

ZimGil commented Nov 8, 2018

@angulae/cli does it's project check using getProjectDetails() at %appdata%\npm\node_modules\@angular\cli\utilities\project.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
future This should be solved later on server Vulnerability
Projects
None yet
Development

No branches or pull requests

1 participant