Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ava dependency (fixing security warning) #4

Closed
wants to merge 1 commit into from
Closed

Update ava dependency (fixing security warning) #4

wants to merge 1 commit into from

Conversation

HoldYourWaffle
Copy link
Contributor

I updated the ava dependency to the latest version, fixing a security warning.
I had to remove a duplicate test in order to make the tests pass again.

@nikitaeverywhere
Copy link
Owner

I've incorporated these changes, thanks! (conflicting PR + a need to drop node v4 support for ava)

@HoldYourWaffle
Copy link
Contributor Author

Good to hear!
Wouldn't the ava update just break node 4 compatability for dev environments?

@HoldYourWaffle HoldYourWaffle deleted the deps branch May 10, 2019 16:53
@nikitaeverywhere
Copy link
Owner

nikitaeverywhere commented May 10, 2019

Yep, just for dev. Anyway, it's not enough to run the test under v4 so I removed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants