Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for Vimeo hash on URLs #91

Closed
gonzalo-massa opened this issue Oct 1, 2021 · 0 comments · Fixed by #90
Closed

Please add support for Vimeo hash on URLs #91

gonzalo-massa opened this issue Oct 1, 2021 · 0 comments · Fixed by #90

Comments

@gonzalo-massa
Copy link
Contributor

gonzalo-massa commented Oct 1, 2021

Hi

There are some issues with this format of Vimeo URLs:

vimeo.com/{video_id}/{hash}
player.vimeo.com/{video_id}?h={hash}

The hash is needed in order to display the video, otherwise it'll show an error (404 most of the time).

I've made a pull request (#90) that fixes this problem. I've tried to follow the code style of the plugins, but had to make some exceptions:

  • parseUrl only searches for the video ID, so I've created a parseHash function, that is called after the result object creation.
  • I've added a new argument (type) to createUrl in order to tell if it's being created in "long" or "embed" mode, because that makes a difference on the way the hash is included (as part of the path for long and has a param for embed).

Please let me know if you have any questions about this.

Thank you,
Gonzalo

@Zod- Zod- linked a pull request Nov 16, 2021 that will close this issue
@Zod- Zod- closed this as completed in #90 Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant