You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The hash is needed in order to display the video, otherwise it'll show an error (404 most of the time).
I've made a pull request (#90) that fixes this problem. I've tried to follow the code style of the plugins, but had to make some exceptions:
parseUrl only searches for the video ID, so I've created a parseHash function, that is called after the result object creation.
I've added a new argument (type) to createUrl in order to tell if it's being created in "long" or "embed" mode, because that makes a difference on the way the hash is included (as part of the path for long and has a param for embed).
Please let me know if you have any questions about this.
Thank you,
Gonzalo
The text was updated successfully, but these errors were encountered:
Zod-
linked a pull request
Nov 16, 2021
that will
close
this issue
Hi
There are some issues with this format of Vimeo URLs:
vimeo.com/{video_id}/{hash}
player.vimeo.com/{video_id}?h={hash}
The hash is needed in order to display the video, otherwise it'll show an error (404 most of the time).
I've made a pull request (#90) that fixes this problem. I've tried to follow the code style of the plugins, but had to make some exceptions:
parseUrl
only searches for the video ID, so I've created aparseHash
function, that is called after theresult
object creation.type
) tocreateUrl
in order to tell if it's being created in "long" or "embed" mode, because that makes a difference on the way the hash is included (as part of the path for long and has a param for embed).Please let me know if you have any questions about this.
Thank you,
Gonzalo
The text was updated successfully, but these errors were encountered: