Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Phong Shader #5

Open
Zeeblur opened this issue Feb 9, 2019 · 2 comments
Open

Fix Phong Shader #5

Zeeblur opened this issue Feb 9, 2019 · 2 comments

Comments

@Zeeblur
Copy link
Owner

Zeeblur commented Feb 9, 2019

Uniforms not correct with instancing
@Zeeblur
Copy link
Owner Author

Zeeblur commented Apr 5, 2019

Uniforms are actually correct. It is the calculation of tangents and binormals that is incorrect. Changing to pre-calculating these within the buffer creation step should rectify this.

@Zeeblur Zeeblur closed this as completed Apr 5, 2019
@Zeeblur Zeeblur reopened this Apr 5, 2019
@Zeeblur
Copy link
Owner Author

Zeeblur commented Apr 5, 2019

Need to add new attribute descriptions for new uniforms (tangents and binormals)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Zeeblur