Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can we help improve the extension? #21

Closed
photex opened this issue Mar 6, 2019 · 2 comments
Closed

How can we help improve the extension? #21

photex opened this issue Mar 6, 2019 · 2 comments

Comments

@photex
Copy link

photex commented Mar 6, 2019

Howdy!

Currently this extension holds a lot of promise and hope :D . There are some things that make it generally hard to use compared to other editors/ides with Rust support.

  • Performance:
    There is a noticeable lag between input to the editor and the response which leads to major editing
    difficulty. I haven't tested this on projects of comparative sizes to figure how it differs by project size or
    complexity. It seems that per-edit the buffer is being re-evaluated synchronously. It isn't clear to me as
    somebody new to visual studio whether that is caused by this extension or just the way the language
    server protocol has been implemented in visual studio in general.

  • Impacts to common editing features:
    The extension gives me fantastic completion options, but clicking on one, or hitting tab do not actually
    trigger the completion. The default completion options are not accurate but tend to work as expected.
    It also isn't clear if the problem lies in visual studio or the extension.

For me personally, completions are less of a problem than the latency issues. I created this issue to just start the conversation about what we can do to help improve things as users.

@ZoeyR
Copy link
Owner

ZoeyR commented Mar 7, 2019

Hi @photex! Both of the issues you have described are issues with the underlying LSP implementation in VS. Completion used to work before something changed in the RLS and exercised the specification in a way that VS did not originally anticipate. The performance issues are also likely due to some parts of the VS API being inherently synchronous. If you could would you be able to download the VS 2019 RC and see if the issues you have noticed still persist there?

@photex
Copy link
Author

photex commented Mar 8, 2019

@dgriffen Everything works really great in VS2019! I guess I'm now looking forward to April 2nd ;)

Cheers!

@photex photex closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants