Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker image build fails - can not parse cargo manifest #214

Closed
ivica7 opened this issue Jan 6, 2019 · 3 comments
Closed

docker image build fails - can not parse cargo manifest #214

ivica7 opened this issue Jan 6, 2019 · 3 comments

Comments

@ivica7
Copy link

ivica7 commented Jan 6, 2019

built with docker 18.09.0 on ubuntu 16.04

Step 12/12 : RUN curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain $RUST_TOOLCHAIN -y     && export PATH=/home/zokrates/.cargo/bin:$PATH     && (cd src;./build_release.sh)     && mv ./src/target/release/zokrates .     && mv ./src/zokrates_cli/examples .     && rustup self uninstall -y     && rm -rf $LIBSNARK_SOURCE_PATH src
 ---> Running in 072882ac0ecb
info: downloading installer
info: syncing channel updates for 'nightly-2018-06-04-x86_64-unknown-linux-gnu'
info: latest update on 2018-06-04, rust version 1.28.0-nightly (29f48ccf3 2018-06-03)
info: downloading component 'rustc'
info: downloading component 'rust-std'
info: downloading component 'cargo'
info: downloading component 'rust-docs'
info: installing component 'rustc'
info: installing component 'rust-std'
info: installing component 'cargo'
info: installing component 'rust-docs'

info: default toolchain set to 'nightly-2018-06-04'
  nightly-2018-06-04 installed - rustc 1.28.0-nightly (29f48ccf3 2018-06-03)


Rust is installed now. Great!

To get started you need Cargo's bin directory ($HOME/.cargo/bin) in your PATH 
environment variable. Next time you log in this will be done automatically.

To configure your current shell run source $HOME/.cargo/env
error: failed to parse manifest at `/home/zokrates/src/zokrates_field/Cargo.toml`

Caused by:
  editions are unstable

Caused by:
  feature `edition` is required

consider adding `cargo-features = ["edition"]` to the manifest
The command '/bin/sh -c curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain $RUST_TOOLCHAIN -y     && export PATH=/home/zokrates/.cargo/bin:$PATH     && (cd src;./build_release.sh)     && mv ./src/target/release/zokrates .     && mv ./src/zokrates_cli/examples .     && rustup self uninstall -y     && rm -rf $LIBSNARK_SOURCE_PATH src' returned a non-zero code: 101
@ivica7
Copy link
Author

ivica7 commented Jan 6, 2019

The image build worked after removing edition = "2018" in zokrates_field/Cargo.toml (see kbknapp/cargo-outdated#141). I am not sure about implications of this, however, I can build the image now.

@Schaeff
Copy link
Member

Schaeff commented Jan 7, 2019

Thanks for pointing this out! We should upgrade the nightly version in Docker

@stefandeml
Copy link
Member

Thanks. The master branch is now updated to support rust edition 2018.
I guess this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants