Added proguard rules allowing consumers of the sdk to minify their app. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylogx
reviewed
Sep 6, 2018
|
@ekanshkaushik Can you please review these rules? |
varunest
approved these changes
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I consume this project through one of it's forks, which supply it through gradle/maven. When doing this, we need proguard rules in order to use minifyEnabled.
I've added the rules in the example project, as well as in your readme, just above the license (tested in 2 projects, one in production at this time)..
I hope this can help future consumers of your work!
This is my first contribution here. Please let me know if there's something I should change before you can approve this.