Refactor, CI & docs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuzhenQin
changed the title
|
关于淘汰数据，我想的是使用一个 _expire 队列，然后可以起一个线程遍历队列清理，其他操作像代码里一样从队头开始清理 |
Zombie123456
requested changes
Jul 13, 2022
| clean 时从队头开始，对于每一个 key 都检查一遍是否超时 | ||
| 直到现在的 datetime > 队头的到期时间 | ||
| 但是 set 太多占用空间就会变大 | ||
| """ |
There was a problem hiding this comment.
关于清理的策略，你这样是很好的，
但是每一次set都会遍历这个队列到适合的位置，会比较浪费性能，
这里我们可以随机选取一定数量的设置有过期时间的key出来，如果过期就delete，
取的这个key的数量我们可以进行优化控制
这样取一个择中的方法，逻辑也更简单，配合我们之后会启一个线程来删除key应该就没有问题了
There was a problem hiding this comment.
而且这样的话，我们的存 有过期时间的key 就可以用 集合，增删改查都是 O(1) 了
There was a problem hiding this comment.
所以说就是 有过期时间的 key -> 加入集合 -> 每次随机选一定量检查是否过期 这样对吗
|
感谢PR，看了一部分代码，给了一点评论，有问题的话，我们可以讨论， 晚上回去在看看，上班摸鱼。。。 |
|
增加了发版 CI，需要设置 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 较乱，如果要 merge 建议 squash 成一个 commit