Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JWT signing for Stacks authentication #102

Closed
kyranjamie opened this issue Apr 7, 2022 · 5 comments
Closed

Support JWT signing for Stacks authentication #102

kyranjamie opened this issue Apr 7, 2022 · 5 comments
Assignees

Comments

@kyranjamie
Copy link
Contributor

kyranjamie commented Apr 7, 2022

As mentioned in Slack, in order for the Stacks Ledger integration to be compatible with the Stack authentication flow, a JWT payload needs to be signed by a key on the "identities keychain", the m/888'/0' derivation path.

This feature would need to accept a JWT payload and return a signature.

The implementation would need to function the same as our TypeScript implementation found here.

  • Is the device capable of handing and signing a JWT?
  • How large of an effort would this be to implement?
@neithanmo
Copy link
Collaborator

@kyranjamie i opened a PR, can you take a look. it omits network version and returns a publicKey using the path you described above.

@kyranjamie
Copy link
Contributor Author

Thanks @neithanmo! Good stuff. (You mean the issue #103 though)

@markmhendrickson
Copy link

@neithanmo To be clear, the PR you've linked above (#104) resolves this particular issue (for complete JWT signing) or simply the one that Kyran has linked (#103, for passing a m/888' leading derivation path as a preliminary fix)?

@neithanmo
Copy link
Collaborator

@neithanmo To be clear, the PR you've linked above (#104) resolves this particular issue (for complete JWT signing) or simply the one that Kyran has linked (#103, for passing a m/888' leading derivation path as a preliminary fix)?

it fixed the issue with the new derivation path. which is required by the JWT feature. later this week will open a PR with the full JWT support.

@neithanmo neithanmo mentioned this issue Apr 27, 2022
Merged
@zboto zboto bot closed this as completed May 20, 2022
@zboto zboto bot reopened this May 23, 2022
@neithanmo
Copy link
Collaborator

neithanmo commented May 24, 2022

closed via #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants