Better Error logging on disk_total_space failure #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add the same kind of check to disk_free_space as well, just a couple lines down? |
|
hmmmm.... looks like this commit is also in #1409 so perhaps we can close this pr out. |
|
yeah we should find and fix all cases where we dont handle failure |
| @@ -1668,6 +1668,10 @@ function getLoad() | |||
| function getDiskPercent() | |||
| { | |||
| $total = disk_total_space(ZM_DIR_EVENTS); | |||
| if ( ! $total ) { | |||
| Error("disk_total_space returned false for " . ZM_DIR_EVENTS ); | |||
| return 0; | |||
There was a problem hiding this comment.
I'm thinking about the value we should return if disk_total_space fails:
- If we return 0, then the purge filter will not trigger and zoneminder will keep recording until writes fail due to disk full. I believe Zoneminder will simply stop running when this happens with a failed to write to disk message.
- if we return 100, then that will cause the purge filter to continually execute because it incorrectly thinks the disk is full. All events will eventually get deleted.
- if we return -1 to signal there was an error, then perhaps we can write additional code to handle that response and/or alert the user.
Thoughts?
Should we consider the third option?
|
Well, I definitely wouldn't want events deleted due to a bug. So we can't return 100. -1 is probably the best thing to do. Filters actually run in the perl code, so this would only affect manual filter runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.