remove extra stuff that I don't think we need because we are the source. Opinions? #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also unconditionally call zmupdate.pl since it should do all the checking of versions to see if anything needs doing. We don't need to be doing that work in a postinst bash script.
| # | ||
| # Get mysql started if it isn't | ||
| # | ||
| if ! $(/etc/init.d/mysql status >/dev/null 2>&1); then |
There was a problem hiding this comment.
I would argue for calling 'server mysql status' over the init.d script
There was a problem hiding this comment.
Doesn't exist on ubuntu
connortechnology
added a commit
that referenced
this pull request
Nov 19, 2013
remove extra stuff that I don't think we need because we are the source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also unconditionally call zmupdate.pl since it should do all the checking of versions to see if anything needs doing.
We don't need to be doing that work in a postinst bash script.
This also means that we don't have to update postinst anymore when we release a new version.