New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Css skins for classic #602
Conversation
…a subdirectory of web/skins/classic/css to find the css files.
… used to determine which set of css files to use.
… used to determine which set of css files to use.
…views and update Makefile.am's to match
…missing elements of the table for the skins tab and cleans up some spacing. Also, use a variable to tell whether to reload the page or not, which is required after you change the skin or css.
… don't need to have it in the SUBDIRS
This looks much better @connortechnology and it doesn't look like it'll affect what I'm doing with my new skin. Regarding the change in options - that doesn't update the DB, or does it? How is the css setting preserved? |
It is not preserved. I will address that in a separate PR. It merely changes the session's setting. |
I haven't been able to test this myself but after looking over the code, I'm OK with it being merged. |
Would be nice if we had a way to preserve use of skin=flat without keeping that folder? Ideas anyone? |
I have it (actually storing it in config) in another PR which I havn't actually made a PR for. Getting PR's merged is like pulling teeth around here. I have two or three more that depend on this one. I'm trying to keep things small and understandable. Of course adding those two options to the config renumbers config entries and means when you update you to zmupdate.pl -f which is really annoying. We need a better config system. |
So hopefully this is more easily understood.
I left out the actual merge of flat, that can happen in another PR.
This just adds the ability to possibly have different CSS's.