small performance improvement when streaming. #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e are going to use it
|
What you've got looks fine to me, but admittedly this is an area of zoneminder where I have not taken the time to get a deep understanding of what is going on. |
|
what I have here has a memleak of course. I have the fix for it, just havn't committed it yet. The debate is guess is the use of malloc to allocate such a small amount of mem vs using and dealing with 4k on the stack |
connortechnology
added a commit
that referenced
this pull request
Jan 29, 2015
small performance improvement when streaming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not be the way to go.
From what I read, we really should be using std::string instead of doing it the C way.
In any event, at least not calling strlen(swap_path) many times is good.
PATH_MAX is 4096 on Linux, and is actually filesystem dependent, so it is silly to even worry about it.
So this saves us 4k-whatever length the swap_path actually is on the stack.
comments?