Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache.conf modifications #968

Merged
merged 1 commit into from Aug 22, 2015
Merged

Conversation

SteveGilvarry
Copy link
Member

Most of these have come from official debian package. Remove trailing slash from ScriptAlias, add Require All Granted and comment out second log option. Comments welcome?

@knight-of-ni
Copy link
Member

Huh, didn't realize we had an apache config under /misc. Always used the distro-specific ones under the /distro folders.

Couple of things:

  1. The script, as it is written, will only work with Apache 2.4. We should probably make it work with Apache 2.2 as well. Here is an example:
    https://github.com/ZoneMinder/ZoneMinder/blob/master/distros/redhat/zoneminder.el7.conf.in

  2. This script has a default virtualhost directive in it. However, most distros will already have a default virtuahost directive installed with the web server package. Will having two <VirtualHost *:80> entries cause an overlap and/or create any other issues?

@SteveGilvarry
Copy link
Member Author

  1. Lines 1 - 10 of that example reminds me to fix that sometime. Also it refers to a line below but I don't think that is there anymore, used to be a line that made the site not work post install due to that "insecurity" of images not being secure. But I will grab the rest of that example and integrate it.
  2. These were mostly patches that the debian package was making and I figured we could merge upstream, but the distro one is better, I will merge them together and update this.

knight-of-ni pushed a commit that referenced this pull request Aug 22, 2015
@knight-of-ni knight-of-ni merged commit 2ed442c into ZoneMinder:master Aug 22, 2015
@knight-of-ni
Copy link
Member

See commit 800d7dd as a follow-up to this pr

@SteveGilvarry SteveGilvarry deleted the apache_conf branch December 3, 2015 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants