Remove shared data warning for purpose query only #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connortechnology
added a commit
that referenced
this pull request
Aug 4, 2015
…ery-warning Remove shared data warning for purpose query only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one case (only) of the shared data not initialized warning, specifically when the Monitor::Monitor constructor is called with query purpose=QUERY. In that case, the deleted warning message cannot be avoided -- mem_ptr is initialized to null, then (after a second of code that cannot be executed when purpose==QUERY) is tested and this warning given.
It also appears to work properly, so I cannot actually see that the mem_ptr needs to be initialized for purpose==QUERY at that point, as all paths I have tested seem to work properly.
This pull does not address whether the other shared data not initialized error, the one that does not end with "some query functions", is correct or not; I did not research it.