Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored Cross Site Scripting - Filters #2642

Closed
joeylane opened this issue Jun 18, 2019 · 5 comments
Closed

Stored Cross Site Scripting - Filters #2642

joeylane opened this issue Jun 18, 2019 · 5 comments

Comments

@joeylane
Copy link

joeylane commented Jun 18, 2019

  • ZoneMinder version 1.32.3
  • Installed from PPA (Ubuntu Xenial)
  • Ubuntu 16.04 Xenial

The 'Filters' page in ZoneMinder 1.32.3 is vulnerable to stored cross site scripting due to improper input sanitation in the 'Name' field. This is the latest version available in the Ubuntu 16.04 PPA. Please see attached screenshots.

1

2

Steps to reproduce the behavior:

  1. Go to the "Filters" page.
  2. In the "Name" field paste in a javascript payload such as "<script>alert('Vulnerable')</script>"
  3. Refresh the page to verify that the payload executes and remains stored through browser sessions.

Expected behavior:
The user input fields should be sanitized. Special characters should be limited or escaped to prevent injection of malicious code.

@welcome
Copy link

welcome bot commented Jun 18, 2019

Thanks for opening your first issue here! Just a reminder, this forum is for Bug Reports only. Be sure to follow the issue template!

@connortechnology
Copy link
Member

This has already been fixed in master.

@rakeshsv
Copy link

This has already been fixed in master

Please can you give commit #

@tamir-ben
Copy link

This has already been fixed in master.

Can we get a commit please?

@SteveGilvarry
Copy link
Member

Do you one better the original issue and closing commit. #2455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants