Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max recursion limit #18

Closed
jinpan opened this issue Jan 25, 2018 · 2 comments · Fixed by MacroFab/jsondiff#1 or #27
Closed

Max recursion limit #18

jinpan opened this issue Jan 25, 2018 · 2 comments · Fixed by MacroFab/jsondiff#1 or #27

Comments

@jinpan
Copy link

jinpan commented Jan 25, 2018

List differences are evaluated recursively, which leads to a very large number of stack frames for long lists and ultimately runtime errors related to max recursion limit.

Are there any plans to implement this iteratively?
@fzumstein
Copy link
Member

if you could do a PR would definitely help :)

@fzumstein fzumstein mentioned this issue Jul 15, 2018
Closed
@cp-macrofab cp-macrofab mentioned this issue Jul 19, 2019
Merged
@prik2693
Copy link

prik2693 commented Jul 25, 2019 •
edited

Hey, can you please update the version with this fix? @cp-macrofab

@cp-macrofab cp-macrofab mentioned this issue Jul 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jinpan @fzumstein @prik2693