fix(openapi): fixed missing schema key #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enudler
requested changes
Sep 25, 2020
|
@enudler then if we have 2 docs -> it means we must make it into a one place |
|
@syncush i wish.. put the problem that our swagger validator and the redoc needs slight changes from each other :| |
|
Can you please provide an example of a needed change, there must be a way |
|
it was quite a long ago when we decided on it to test this you can do:
http://localhost:8000/indexapiref.html#operation/create-a-test you will see that it doesn't list the request body very well.. |
|
btw it can be also the opposite, that redoc does it well and we used slightly changed swagger to support validators |
syncush
force-pushed
the
fix-openapi-missing-key
branch
from
a109c6d
to
03c486f
Compare
|
@enudler I added a validator test for the |
syncush
force-pushed
the
fix-openapi-missing-key
branch
from
03c486f
to
d3edcee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further information:
A schema key was missing