wip

Gemfile.lock

@@ -137,4 +137,5 @@ DEPENDENCIES
   rake
   response_mate!
   rspec (~> 2.14.0)
+  rubocop
   simplecov (~> 0.8.2)

bin/response_mate

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-# coding: utf-8
 
 require 'response_mate'
 

lib/response_mate.rb

@@ -1,4 +1,3 @@
-# coding: utf-8
 require 'thor'
 require 'colored'
 require 'awesome_print'

lib/response_mate/cli.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 module ResponseMate
   class CLI < ::Thor
     package_name 'response_mate'
@@ -16,24 +14,24 @@ def record
 
     desc 'inspect [key1,key2]', 'Perform requests and print their output'
     method_option :requests_manifest, aliases: '-r'
-    def inspect(*keys)
+    def inspect(*keys) # rubocop:disable Lint/UnusedMethodArgument
       ResponseMate::Commands::Inspect.new(args, options).run
     end
 
     desc 'setup', 'Initialize the required directory structure'
-    def setup(output_dir = '')
+    def setup(output_dir = '') # rubocop:disable Lint/UnusedMethodArgument
       ResponseMate::Commands::Setup.new(args, options).run
     end
 
     desc 'clear [output_dir]', 'Delete existing response files'
-    def clear(output_dir = '')
+    def clear(output_dir = '') # rubocop:disable Lint/UnusedMethodArgument
       ResponseMate::Commands::Clear.new(args, options).run
     end
 
-    desc 'list [request_type] (requests or recordings)',
-      'List available recordings or keys to record'
+    desc 'list [request_type] (requests or recordings)', 'List available recordings' \
+    'or keys to record'
     method_option :requests_manifest, aliases: '-r'
-    def list(type = 'requests')
+    def list(type = 'requests') # rubocop:disable Lint/UnusedMethodArgument
       ResponseMate::Commands::List.new(args, options).run
     end
 
@@ -43,8 +41,7 @@ def version
     end
     map ['--version'] => :version
 
-    desc 'export',
-      'Export manifest or environment to one of the available formats'
+    desc 'export', 'Export manifest or environment to one of the available formats'
     method_option :requests_manifest, aliases: '-r'
     method_option :format, required: true, aliases: '-f', default: 'postman'
     method_option :pretty, aliases: '-p', default: false

lib/response_mate/commands/base.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 module ResponseMate
   module Commands
     class Base

lib/response_mate/commands/clear.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 module ResponseMate
   module Commands
     # Handles the invocation of the clear command
@@ -11,15 +9,15 @@ def initialize(args, options)
         @options = options.dup
 
         @output_dir = if args.present?
-          args.first
-        else
-          ResponseMate.configuration.output_dir
-        end
+                        args.first
+                      else
+                        ResponseMate.configuration.output_dir
+                      end
       end
 
       def run
         FileUtils.rm_rf(output_dir + '.')
-        puts "All clean and shiny!"
+        puts 'All clean and shiny!'
       end
     end
   end

lib/response_mate/commands/export.rb

@@ -1,9 +1,6 @@
-# coding: utf-8
-
 module ResponseMate
   module Commands
     class ResponseMate::Commands::Export < Base
-
       def initialize(args, options)
         super(args, options)
         @type = args.first || 'requests'

lib/response_mate/commands/inspect.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 class ResponseMate::Commands::Inspect < ResponseMate::Commands::Base
   attr_reader :inspector
   attr_accessor :history

lib/response_mate/commands/list.rb

@@ -1,4 +1,3 @@
-# coding: utf-8
 class ResponseMate::Commands::List < ResponseMate::Commands::Base
   def run
     environment = ResponseMate::Environment.new(options[:environment])
@@ -24,10 +23,10 @@ def ask_action
   end
 
   def ask_key(available_keys)
-    choose { |menu|
+    choose do |menu|
       menu.prompt = 'Which one?'
       menu.choices(*available_keys)
-    }.to_s
+    end.to_s
   end
 
   def perform_action(action, key)

lib/response_mate/commands/record.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 module ResponseMate
   module Commands
     # Handles the invocation of the record command

lib/response_mate/commands/setup.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 module ResponseMate
   module Commands
     # Handles the invocation of the setup command
@@ -11,10 +9,10 @@ def initialize(args, options)
         @options = options.dup
 
         @output_dir = if args.present?
-          args.first
-        else
-          ResponseMate.configuration.output_dir
-        end
+                        args.first
+                      else
+                        ResponseMate.configuration.output_dir
+                      end
       end
 
       def run

lib/response_mate/connection.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 # This class provides a layer above the HTTP client
 class ResponseMate::Connection
   delegate :params, to: :client

lib/response_mate/core.rb

@@ -1,10 +1,9 @@
-# coding: utf-8
 # The main module of the tool contains configuration code and some constants
 module ResponseMate
   class OutputDirError < StandardError; end
   class KeysNotFound < StandardError; end
 
-  HTTP_METHODS = %w(GET POST PUT PATCH DELETE HEAD OPTIONS)
+  HTTP_METHODS = %w[GET POST PUT PATCH DELETE HEAD OPTIONS]
   DEFAULT_HEADERS = { 'User-Agent' => 'Response-Mate' }
 
   class << self

lib/response_mate/environment.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 class ResponseMate::Environment
   attr_accessor :filename, :env, :environment_text
 

lib/response_mate/exporter.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 module ResponseMate
   class Exporter
     attr_accessor :format, :handler, :manifest, :environment, :resource

lib/response_mate/exporters/postman.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 module ResponseMate::Exporters
   # Handles exporting to postman format
   # Example output

lib/response_mate/exporters/postman/collection.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 class ResponseMate::Exporters::Postman
   # Handles exporting to postman format
   # Example output

lib/response_mate/exporters/postman/environment.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 class ResponseMate::Exporters::Postman
   # Handles exporting to postman format
   # Example output

lib/response_mate/inspector.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 class ResponseMate::Inspector
   attr_accessor :conn, :manifest
 
@@ -9,7 +7,7 @@ def initialize(args = {})
     @conn = ResponseMate::Connection.new
   end
 
-  def inspect_key(key, options = {})
+  def inspect_key(key)
     request = manifest.requests.find { |r| r.key == key }
 
     puts request.to_cli_format

lib/response_mate/manifest.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 class ResponseMate::Manifest
   attr_accessor :filename, :requests, :requests_text, :environment
   attr_reader :name, :description
@@ -18,7 +16,7 @@ def preprocess_manifest
       exit 1
     end
 
-    if environment.present?
+    if environment.present? # rubocop:disable Style/GuardClause
       @requests_text = Mustache.render(@requests_text, environment.try(:env) || {})
     end
   end
@@ -34,17 +32,17 @@ def parse
   end
 
   def requests_for_keys(keys)
-    if keys.present?
-      existing_keys = requests.map(&:key)
-      missing_keys = keys - existing_keys
+    return [] if keys.empty?
+
+    existing_keys = requests.map(&:key)
+    missing_keys = keys - existing_keys
 
-      if missing_keys.present?
-        raise ResponseMate::KeysNotFound.new(missing_keys.join(','))
-      end
+    if missing_keys.present?
+      fail ResponseMate::KeysNotFound.new(missing_keys.join(','))
+    end
 
-      requests.select! do |r|
-        keys.include? r.key
-      end
+    requests.select! do |r|
+      keys.include? r.key
     end
   end
 end

lib/response_mate/recorder.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 module ResponseMate
   # Handles recording requests
   class Recorder

lib/response_mate/request.rb

@@ -1,14 +1,12 @@
-# coding: utf-8
-
 class ResponseMate::Request < OpenStruct
   delegate :[], to: :request
 
   def normalize!
-    unless ResponseMate::HTTP_METHODS.include? self.request[:verb]
-      self.request[:verb] = 'GET'
+    unless ResponseMate::HTTP_METHODS.include? request[:verb]
+      request[:verb] = 'GET'
     end
 
-    self.request[:url] = URI.encode(adjust_scheme(request[:url], request[:scheme]))
+    request[:url] = URI.encode(adjust_scheme(request[:url], request[:scheme]))
 
     self
   end

lib/response_mate/tape.rb

@@ -1,8 +1,6 @@
-# encoding: utf-8
-
 class ResponseMate::Tape
   def write(key, request, response, meta = {}, output_dir = nil)
-    output_dir = output_dir || ResponseMate.configuration.output_dir
+    output_dir ||= ResponseMate.configuration.output_dir
 
     output_path = File.join output_dir, "#{key}.yml"
 
@@ -30,7 +28,10 @@ def _utf8_encode(object)
     when String
       object.force_encoding('UTF-8')
     when Hash
-      object.each { |k, v| k = _utf8_encode(v); v = _utf8_encode(v) }
+      object.each do |k, v|
+        k = _utf8_encode(v)
+        v = _utf8_encode(v)
+      end
     when Array
       object.each { |v| _utf8_encode(v) }
     end

lib/response_mate/version.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 module ResponseMate
   VERSION = '0.2.2'
 end

response_mate.gemspec

@@ -1,4 +1,3 @@
-# coding: utf-8
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'response_mate/version'
@@ -11,17 +10,18 @@ Gem::Specification.new do |spec|
   spec.description   = <<-DESC
     Cli tool to make inspecting and recording HTTP requests fun again
   DESC
-  spec.summary       = %q{A cli tool for browsing and recording api requests with ease}
+  spec.summary       = %q(A cli tool for browsing and recording api requests with ease)
   spec.homepage      = 'https://github.com/Zorbash/response_mate'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  spec.executables   = spec.files.grep(/^bin\//) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(/^(test|spec|features)\//)
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rubocop'
 
   spec.add_dependency 'thor', '~> 0.19'
   spec.add_dependency 'awesome_print'

spec/lib/response_mate/cli_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ResponseMate::CLI do
@@ -28,7 +26,7 @@
     end
   end
 
-  describe'#inspect' do
+  describe '#inspect' do
     before do
       allow(ResponseMate::Commands::Inspect).to receive(:new).and_return(command)
     end

spec/lib/response_mate/commands/inspect_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ResponseMate::Commands::Inspect do
@@ -16,7 +14,7 @@
           end
         end
 
-        expect(error_output.strip).to eq("At least one key has to be specified".red)
+        expect(error_output.strip).to eq('At least one key has to be specified'.red)
       end
     end
 
@@ -46,7 +44,7 @@
 
       it 'includes the response status' do
         expect(captured_output).
-          to include(":status => #{fake_response_user_issues[:status].to_s}")
+          to include(":status => #{fake_response_user_issues[:status]}")
       end
 
       it 'includes the response body' do

spec/lib/response_mate/commands/list_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ResponseMate::Commands::List do