Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: Properly returned requests object #10

Merged
merged 1 commit into from Jan 25, 2016

Conversation

avgerin0s
Copy link
Contributor

Array#select! returns something only if a mutation happened,
else it returns nil.

Now, #requests_for_keys always returns the remaining keys.

Array#select! returns something only if a mutation happened,
else it returns nil.

Now, #requests_for_keys always returns the remaining keys.
@zorbash zorbash added the bug label Jan 25, 2016
@zorbash
Copy link
Owner

zorbash commented Jan 25, 2016

Issue Reproduction

  1. Create a requests manifest containing a single request key.
  2. Try to record this specific key.
  3. 💣

zorbash added a commit that referenced this pull request Jan 25, 2016
manifest: Properly returned requests object
@zorbash zorbash merged commit 4fb3bf0 into zorbash:master Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants