Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag when using tumbnails #3

Closed
ang3lo-azevedo opened this issue May 14, 2022 · 5 comments
Closed

Lag when using tumbnails #3

ang3lo-azevedo opened this issue May 14, 2022 · 5 comments

Comments

@ang3lo-azevedo
Copy link

Hello, I have a problem.
When watching anything on mpv the tumbnails from osc tethys lag all the interface and even make it freeze.

Could you help me?

Thanks

@Zren
Copy link
Owner

Zren commented May 14, 2022

Atm, the thumbnail generation is blocking. I added a debounce delay to generate the thumbnail if you stop moving the mouse for 200ms, but it's not working very well.

I was hoping to keep this as a single script to make it easier to install, but it seems there's a reason that https://github.com/TheAMM/mpv_thumbnail_script/releases is two different lua scripts.

I've tested a quick refactor using mpv_thumbnail_script_server.lua and it seems to work well. I've just gotta polish it and remove my old thumbnail code before releasing it.

@ang3lo-azevedo
Copy link
Author

Thank you!

@ang3lo-azevedo
Copy link
Author

And how can I make the tumbnails work on remote files?

@Zren
Copy link
Owner

Zren commented May 15, 2022

https://github.com/Zren/mpv-osc-tethys#mpv_thumbnail_scriptconf

# Allow thumbnailing network paths (naive check for "://")
thumbnail_network=yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants