Node Labels #7
Node Labels #7
Conversation
|
That is why I made the parameters all titled |
|
@ryanpeach Thank you! This is great! I'll test this out later this today, but looking at it quickly, it looks great! |
|
We might be able to simplify this by using text as an encoding I just learned, but I think this gives us more control. |
There was a problem hiding this comment.
Although I'm not a fan of networkx's argument naming--I like your labeling much more!--I think we should follow it exactly. I'd like nx_altair's draw module to mirror networkx's draw module (see here). That way, a user can use their old networkx plotting code with nx_altair.
I think there is a big push to define a visualization grammar for networks happening here. When that stabilizes, we can update nx_altair to follow that grammar.
| @@ -253,7 +253,7 @@ def draw_networkx_nodes( | |||
| elif alpha is not None: | |||
| raise Exception("alpha must be a string or None.") | |||
|
|
|||
| ##### alpha | |||
| ##### cmap | |||
| if isinstance(cmap, str): | |||
nx_altair/draw_altair.py
Outdated
| chart=None, | ||
| layer=None, | ||
| nodelist=None, | ||
| node_label_size=15, |
There was a problem hiding this comment.
node_label_sizeshould befont_sizenode_label_colorshould befont_colornode_labelshould belabels.
| @@ -281,6 +281,119 @@ def draw_networkx_nodes( | |||
|
|
|||
| return node_chart | |||
|
|
|||
| def draw_networkx_nodes_labels( | |||
| @@ -289,6 +402,9 @@ def draw_networkx( | |||
| edgelist=None, | |||
| node_size=300, | |||
| node_color='red', | |||
| node_label=None, | |||
There was a problem hiding this comment.
node_label_sizeshould befont_sizenode_label_colorshould befont_colornode_labelshould belabels.
|
This is great! Thank you for your work on this. I submitted a review--mostly just renaming variables. I tested out the code and everything works great. If you have any questions, ping me here. |
|
This PR was auto-closed because it was merged in PR #10. |
I added
draw_networkx_nodes_labelstodraw_altair.pywith the following added parameters:node_label_size: scalar or stringSize of nodes (default=15). If an array is specified it must be the
same length as nodelist.
node_label_color: color string, or array of floatsNode color. Can be a single color format string (default='r'),
or a sequence of colors with the same length as nodelist.
If numeric values are specified they will be mapped to
colors using the cmap and vmin,vmax parameters. See
matplotlib.scatter for more details.
node_label: stringThe name of the node attribute to treat as a label.
Limited testing shows that it works as expected, though I haven't yet tested color.