transparency bug in concatenate_videoclips()

[clauswilke]

The function concatenate_videoclips() has three transparency bugs:

1. The default should be transparent=True, not transparent=False. The purpose of this function is simply to stitch multiple videoclips together. It makes no sense to remove transparency in the process by default.
2. If I set transparent=True, the function crashes. The offending line is line 85 in:
   https://github.com/Zulko/moviepy/blob/master/moviepy/video/compositing/concatenate.py
   The variable clips that is used in the list comprehension is not defined. It should be clipslist.
3. If I set transparent=False, I would expect that transparency is replaced by the background color given as bg_color argument. As far as I can see, that is not the case, however. Transparency is replaced by black.

[Zulko]

Indeed. Yeek, I definitely need a test suite, it used to work and I wonder how long this has been broken. I'm on it (and the ImageSequence one too).

[clauswilke]

Great, thanks!

What's the best way to install the latest github version of the code?

[Zulko]

Rather with the setup.py:

(sudo) python setup.py install

Another solution is with PIP:

sudo pip install git+git://github.com/Zulko/moviepy.git

So that it's clear: I didn't upload any fix for this issue yet.

[clauswilke]

Thanks!

So that it's clear: I didn't upload any fix for this issue yet.

I'm aware. I just fixed the clips vs clipslist issue myself in my installed code, so I could complete the movie I wanted to make.

[ghost]

closing.. this issue looks resolved.

[keikoro]

@Earney I'm guessing #104 can then also be closed?

[ghost]

I am not sure if issue 104 can be closed. We will have to verify, if the issue is still valid.