Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bytes object is recognised as a string #120

Closed
grimley517 opened this issue Feb 4, 2015 · 3 comments
Closed

a bytes object is recognised as a string #120

grimley517 opened this issue Feb 4, 2015 · 3 comments

Comments

@grimley517
Copy link
Contributor

Not sure if this is an issue, or if this should happen. Under the general tools there is a function 'is_string" When I feed it a byte string b"hello in bytes" I expect this to fail as it is a bytes object, not a string object. However the is_string function returns that this is a string.

@grimley517 grimley517 mentioned this issue Feb 4, 2015
@ghost
Copy link

ghost commented Mar 9, 2017

PR #475 tries to address this issue. I'm not sure how is_string should respond to bytes objects. I've modified this function to work the same between py2 and py3. If I'm wrong, we can document an issue, and then know how to respond to this.

@keikoro
Copy link
Collaborator

keikoro commented Dec 16, 2018

@Earney Going through old issues - I can see one PR connected to this one here was merged, another wasn't. Can this issue (and the other PR) be closed?

@grimley517
Copy link
Contributor Author

yes - I think that this was dealt with previously.

@keikoro keikoro closed this as completed Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants