Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential bug of use_clip_fps_by_default #1563

Closed
charmie11 opened this issue May 14, 2021 · 2 comments
Closed

potential bug of use_clip_fps_by_default #1563

charmie11 opened this issue May 14, 2021 · 2 comments
Labels
bug Issues that report (apparent) bugs.

Comments

@charmie11
Copy link

use_clip_fps_by_default deletes specified fps information from function arguments.

At the end of the decorator, a and new_a are set as follows. I guess names or fun() is the cause of this bug.

names = ('kw',)
a = ('video.mp4', 30, 'libx264')
new_a = ['video.mp4']
k = {'audio_codec': 'aac', 'temp_audiofile': 'tmp.m4a'}
new_k = {'audio_codec': 'aac', 'temp_audiofile': 'tmp.m4a'}
  • Python: 3.6.10
  • MoviePy: 1.0.3
  • OS: Ubuntu 20.04
@mondeja
Copy link
Collaborator

mondeja commented May 19, 2021

This has been possibly fixed by #1565. Could you try with the repository master branch (pip install -e git+https://github.com/Zulko/moviepy.git#egg=moviepy) or share a minimal reproducible example?

@mondeja mondeja added the needs-more-info Waiting for submitter's reply, feedback, updates,... label May 19, 2021
@charmie11
Copy link
Author

OMG, I tried and it worked!!
Thanks for the advice :)

@mondeja mondeja added bug Issues that report (apparent) bugs. and removed needs-more-info Waiting for submitter's reply, feedback, updates,... labels Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that report (apparent) bugs.
Projects
None yet
Development

No branches or pull requests

2 participants