Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing Information, Frame Values in Time - type hints for all of the parameters and returns. #1695

Open
Kaszanas opened this issue Nov 22, 2021 · 0 comments
Labels
design-decisions Discussion of ideas, suggestions, questions relevant to (re)design decision-making process. feature-request Request for a new feature or additional functionality.

Comments

@Kaszanas
Copy link

Currently I am developing a library on top of moviepy.
As I go deeper into my own code I find that there is limited type information provided on the moviepy side.

I tend to have to look at the source code in order to find answers on how to properly interface with certain APIs.
In video editing there are multiple uses for creating subclips accurately up to a single frame.

Therefore I would like to propose features as follows:

  1. Being able to provide the number of frame to all of the t parameters in methods such as .subclip(t_start, t_end)
  2. Being able to provide the time as a float e.g. .subclip(t_start: float | int, t_end: float | int, frames:bool = False)
  3. Type annotations for function / method parameters.

Conversion could be handled internally.

@Kaszanas Kaszanas added the feature-request Request for a new feature or additional functionality. label Nov 22, 2021
@Kaszanas Kaszanas changed the title Typing Information - type hints for all of the parameters and returns Typing Information, Frame Values in Time - type hints for all of the parameters and returns. Nov 22, 2021
@keikoro keikoro added the design-decisions Discussion of ideas, suggestions, questions relevant to (re)design decision-making process. label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-decisions Discussion of ideas, suggestions, questions relevant to (re)design decision-making process. feature-request Request for a new feature or additional functionality.
Projects
None yet
Development

No branches or pull requests

2 participants