Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAC support for mp4 #344

Closed
jeromegrosse opened this issue Oct 25, 2016 · 1 comment
Closed

AAC support for mp4 #344

jeromegrosse opened this issue Oct 25, 2016 · 1 comment
Labels
bug Issues that report (apparent) bugs.

Comments

@jeromegrosse
Copy link
Contributor

In this pull request, the AAC compatibility was added to MoviePy by passing -strict -2 to ffmpeg.

Between then and now, some changes have been done. The -struct -2 is still being passed to ffmpeg but it is not possible to pass the kwarg audio_codec="aac" while writing an mp4 to VideoClip without getting the error The audio_codec you chose is unknown by MoviePy.
@jeromegrosse jeromegrosse mentioned this issue Oct 25, 2016
Merged
@mbeacom
Copy link
Collaborator

mbeacom commented Mar 6, 2017

Resolved in #345.

@mbeacom mbeacom closed this as completed Mar 6, 2017
@mbeacom mbeacom added the bug Issues that report (apparent) bugs. label Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues that report (apparent) bugs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeromegrosse @mbeacom