Parameter color in ColorClip

[furas]

Documentation shows example with color parameter

clip = ColorClip(size=(460,380), color=[R,G,B])

http://zulko.github.io/moviepy/getting_started/clips.html

but code expects col parameter

def __init__(self, size, col=(0, 0, 0), ismask=False, duration=None):

https://github.com/Zulko/moviepy/blob/master/moviepy/video/VideoClip.py#L1036

[tburrows13]

Can confirm. Can we change col to color in the code please? Readability counts

[keikoro]

@Gloin1313 I think I'd rather col were kept and the documentation adapted because people spell the word differently (colour vs. color). Using the shortcut gets rid of the problem.

[tburrows13]

Well, I would naturally spell it colour, but I am well accustomed to spelling it color for anything like this, where I'd expect American spellings to prevail. Still, I don't really mind either way.

[keikoro]

I'd also spell it colour but I think being able to switch effortlessly is something that's easier for some than it is for others (could depend on everyday use, or even general level of English). I have definitely got this wrong in CSS despite knowing how I'm supposed to spell it!

I'm also not sure if the spelling is consistent (edit: consistenly A.E. or B.E.) throughout the entire codebase and documentation (I only know I've seen what looked like Frenchisms to me).

[ghost]

Why not color and colour as parameters? We would complain if both vars are set and they are not equal.

[tburrows13]

If no-one objects, I'll write this. I'll also include a DeprecationWarning if col is used.

[Zulko]

Can we go for color (and color only) ? col is not "verbose" enough. colour is less used. Having both color and colour would be confusing.

[tburrows13]

Sure. But I think we need a Deprecation error is col is used, because we are changing the API here.

[ghost]

closing.. PR 424 was merged into repo to fix this issue.