Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gif_writers.py uses an undefined constant #64

Closed
TheRushingWookie opened this issue Sep 22, 2014 · 1 comment
Closed

gif_writers.py uses an undefined constant #64

TheRushingWookie opened this issue Sep 22, 2014 · 1 comment

Comments

@TheRushingWookie
Copy link

Hi, my linter turned up an undefined variable found in your library when i was browsing through it

line 161/162 in gif_writers.py

        proc1 = sp.Popen(cmd1+['-r', "%.02f"%fps, filename],
                         stdin=sp.PIPE, stdout=DEVNULL)

should be

        proc1 = sp.Popen(cmd1+['-r', "%.02f"%fps, filename],
                         stdin=sp.PIPE, stdout=os.devnull)
@Zulko
Copy link
Owner

Zulko commented Sep 22, 2014

Thanks ! That's a blunder I made when reorganizing the code, it is now fixed. Just so you know, I actually use two devnulls, os.devnull in Python 2 or subprocess.DEVNULL in Python 3, hence the generic DEVNULL constant.

@Zulko Zulko closed this as completed Sep 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants