Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set all filehandles to make moviepy work in cx_freeze win32gui #67

Closed
bobatsar opened this issue Sep 25, 2014 · 3 comments
Closed

set all filehandles to make moviepy work in cx_freeze win32gui #67

bobatsar opened this issue Sep 25, 2014 · 3 comments

Comments

@bobatsar
Copy link
Contributor

If moviepy is bundled in a cx_freeze win32gui app, all three filehandles (stdout, stderr and stdin) have to be set. If only one of them is not set (default=None) an "invalid filehandle" exception is thrown and moviepy can not be used.

This is already done e.g. in ffmpeg_writer.py by setting stdout to DEVNULL but unfortunately not at all Popen calls.

Is it possible to set these filehandles everywhere?

Thanks

P.S.: Is it ok to submit these issues here or shoud a fork be generated with a pull request? I have not yet worked with pull requests...
@bobatsar bobatsar mentioned this issue Sep 25, 2014
Merged
@bobatsar
Copy link
Contributor Author

I just opened pull request #69 with the suggested changes

@Zulko
Copy link
Owner

Zulko commented Oct 9, 2014

Can I close this now that I merged your pull request ?

@bobatsar
Copy link
Contributor Author

yes, you can close it. Thanks

@Zulko Zulko closed this as completed Oct 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zulko @bobatsar