Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overly Restrictive Requirements #767

Closed
GadgetSteve opened this issue Apr 17, 2018 · 3 comments
Closed

Overly Restrictive Requirements #767

GadgetSteve opened this issue Apr 17, 2018 · 3 comments

Comments

@GadgetSteve
Copy link

Currently moviePy has a requirements of:

  • decorator==4.0.11 but the current version is 4.3.0
  • imageio==2.1.2 but the current version is 2.3.0
  • tqdm==4.11.2 but the current version is 4.23.0
  • numpy
    this seems overly restrictive apart from numpy - it is generally considered best practice to state minimum package versions, (lowest tested), and only add maximums or exclusions where there are known problems.
@tburrows13
Copy link
Collaborator

I’m no expert, but from setup.py:

requires = [
    'decorator>=4.0.2,<5.0',
    'imageio>=2.1.2,<3.0',
    'tqdm>=4.11.2,<5.0',
    'numpy',
    ]

That looks like we’re not specifying exact versions, so I’m not sure we need to change anything. Please correct me if I’m wrong though.

@GadgetSteve
Copy link
Author

@tburrows13 - the problem is that I, like probably most people, am using a simple pip install -U moviepy and getting the version from PyPi - the code you quote above does address this issue but there has not been an update of the version number or a publish to PyPi since that change.

I will close this and eagerly await the next release to PyPi.

@tburrows13
Copy link
Collaborator

Ok, pushing a new release is high priority for me right now, you can see progress at #742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants