Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Add to formula a option to change default runner #859

Open
angeliski opened this issue Feb 15, 2021 · 3 comments
Open

Add to formula a option to change default runner #859

angeliski opened this issue Feb 15, 2021 · 3 comments
Labels
📚 documentation Improvements or additions to documentation ✔️ refined ISSUE refined by the Ritchie Team ✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
Milestone

Comments

@angeliski
Copy link

What would you like to be added:
When we run rit init we choose between local and docker. But in some cases, is better to run (or maybe only possible) to run in a single environment.
Ex: Run docker operations like exec, or maybe docker-compose up
I understand we can use flags to "change" that behavior, but the developer need to know that is only possible to run from outside the docker.

A nice approach could be provide a metadata field where we can specify some restrictions
Ex:

{
  "dockerImageBuilder": "dockerImage",
  "inputs": [],
  "runtimes": ["local", "docker"]
}

Why is this needed:

Some operations need to run outside from docker and is a better experience if the developer doesn't need to find why is getting error inside the docker.

@GuillaumeFalourd
Copy link
Contributor

Hi @angeliski , and thank you for opening this ISSUE 🚀

Today there is a metadata.json file in each formula to get this information.

However, this information is only displayed on the formula portal and your suggestion could be useful to bring this information on the CLI for all users, as they won't know if a formula can be executed through docker without checking the formula implementation.

Our team will refine this feature and let you know which solution will be implemented. Feel free to contribute as well if you wish, we can discuss the solution here 👍🏼

@GuillaumeFalourd GuillaumeFalourd added 📚 documentation Improvements or additions to documentation 🔨 improvement Improvement in features ✨ feature Suggest a new feature or enhancement to the Ritchie project labels Feb 17, 2021
@angeliski
Copy link
Author

Nice @GuillaumeFalourd
Not only bring that information on CLI but use that how a priority execution.
When I try to use a formula where the execution is different from my init option, the runner could follow the use value defined in metadata.json

@henriquemoraeszup
Copy link
Contributor

Thanks @angeliski ! it is a nice suggestion and could put our metadata to a good use

@henriquemoraeszup henriquemoraeszup added ✔️ refined ISSUE refined by the Ritchie Team and removed 🔨 improvement Improvement in features labels Feb 18, 2021
@henriquemoraeszup henriquemoraeszup added this to the 2.11.0 milestone Mar 8, 2021
@GuillaumeFalourd GuillaumeFalourd modified the milestones: 2.11.0, 3.0.0 Jun 2, 2021
@GuillaumeFalourd GuillaumeFalourd added this to To do in Ritchie V3 Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📚 documentation Improvements or additions to documentation ✔️ refined ISSUE refined by the Ritchie Team ✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
Development

No branches or pull requests

3 participants