Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Change the input flags delimiter to support Windows for double quotes #871

Open
fabianofernandeszup opened this issue Feb 22, 2021 · 2 comments
Labels
🪲 bug Report a bug encountered while operating Ritchie 📚 documentation Improvements or additions to documentation good first issue Good for newcomers ✔️ refined ISSUE refined by the Ritchie Team waiting reply Waiting for an answer to a comment 💠 Windows This issue or pull request is specific to the Windows operating system
Projects
Milestone

Comments

@fabianofernandeszup
Copy link
Contributor

What happened:
In windows, input flags do not accept single quotes, just double quotes or without quotes for words without spaces.
On Linux and Mac it is possible to use single and double quotes.

My suggestion is to standardize with double quotes to suit all systems equally.

Error Print
image

What you expected to happen:

These are the only changes needed.

How to reproduce it (as minimally and precisely as possible):

Run any formula with input flags in the CMD on windows using single quotes and you will see the error.

Environment:

  • Ritchie version (use rit --version): 2.9.0
  • Operating System: Windows
@fabianofernandeszup fabianofernandeszup added 🪲 bug Report a bug encountered while operating Ritchie 💠 Windows This issue or pull request is specific to the Windows operating system labels Feb 22, 2021
@henriquemoraeszup
Copy link
Contributor

@fabianofernandeszup can you ensure that double quotes would run in any kind of command prompt? Is there some prompt in which double quotes would not work?

@henriquemoraeszup henriquemoraeszup added this to the 2.11.0 milestone Mar 8, 2021
@henriquemoraeszup henriquemoraeszup added the ✔️ refined ISSUE refined by the Ritchie Team label Apr 19, 2021
@GuillaumeFalourd GuillaumeFalourd removed this from the 2.11.0 milestone Jun 2, 2021
@GuillaumeFalourd GuillaumeFalourd added 📚 documentation Improvements or additions to documentation good first issue Good for newcomers labels Jun 2, 2021
@fabianofernandeszup fabianofernandeszup added this to To do in Release 2.12.0 via automation Jun 3, 2021
@GuillaumeFalourd GuillaumeFalourd removed this from To do in Release 2.12.0 Jun 30, 2021
@fabianofernandeszup fabianofernandeszup added the waiting reply Waiting for an answer to a comment label Jul 7, 2021
@fabianofernandeszup
Copy link
Contributor Author

fabianofernandeszup commented Jul 7, 2021

An issue will be opened in cobra related to this subject: https://github.com/spf13/cobra

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🪲 bug Report a bug encountered while operating Ritchie 📚 documentation Improvements or additions to documentation good first issue Good for newcomers ✔️ refined ISSUE refined by the Ritchie Team waiting reply Waiting for an answer to a comment 💠 Windows This issue or pull request is specific to the Windows operating system
Projects
Development

No branches or pull requests

3 participants