Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of Duplicate Notes #665

Closed
kmpoppe opened this issue Oct 21, 2023 · 2 comments
Closed

Creation of Duplicate Notes #665

kmpoppe opened this issue Oct 21, 2023 · 2 comments
Labels
bug Something isn't working notes Notes and drawing mode
Milestone

Comments

@kmpoppe
Copy link

kmpoppe commented Oct 21, 2023

Albeit in a much smaller scale than other editors, I also found ED creating notes in the same place twice.

These are

  1. https://osm.org/note/3949330 and https://osm.org/note/3949331
    as well as
  2. https://osm.org/note/3949332 and https://osm.org/note/3949333

The notes under 1 where created in the exact same second, the notes under 2 likewise 2 seconds later.

Could

saveNote(BaseNote note, {bool notify = true}) async {
possibly check to only insert notes into the database awaiting upload when there isn't a note already with the same lat/lon?

@Zverik Zverik added bug Something isn't working notes Notes and drawing mode labels Nov 4, 2023
@Zverik Zverik added this to the 4.2 milestone Nov 4, 2023
@Zverik Zverik modified the milestones: 4.2, 5.0 Feb 19, 2024
@Zverik
Copy link
Owner

Zverik commented Apr 21, 2024

Well it doesn't download notes in the area before uploading them. Duplicate notes should be an error indeed. In 5.0 notes process has been reworked — let's see if we get duplicates later.

@Zverik Zverik modified the milestones: 5.0, 5.1 Apr 21, 2024
@Zverik
Copy link
Owner

Zverik commented May 6, 2024

Closing this because with 5.0 the mechanism is a bit different. We'll see how it goes.

@Zverik Zverik closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working notes Notes and drawing mode
Projects
Status: Done
Development

No branches or pull requests

2 participants