Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add folded lightcurves to the 'group' page #59

Closed
Tracked by #54
janvanroestel opened this issue Jan 21, 2022 · 7 comments
Closed
Tracked by #54

add folded lightcurves to the 'group' page #59

janvanroestel opened this issue Jan 21, 2022 · 7 comments

Comments

@janvanroestel
Copy link
Collaborator

janvanroestel commented Jan 21, 2022

We need to be able to see the folded lightcurve on the 'group' page, instead of clicking on the objects and having to open a new window. This needs to be done in skyportal.

@mcoughlin
Copy link
Collaborator

@janvanroestel Do you mean the source table page?

@AshishMahabal
Copy link
Collaborator

I see that the phased light curves are now seen on the group page. Thats is great (and very helpful).
I noticed that not all sources have the phased light curves though. Any idea why? I have attached a picture. (what is the "0" following the "No spectra exist"?)

Also, can we add the period itself - may be on the x-label, or the top-label?

(Is what is called DR8 the DR8 of SDSS or ZTF? That should be clarified in that figure's caption).

Screen Shot 2022-03-07 at 10 18 18 AM

@mcoughlin
Copy link
Collaborator

@AshishMahabal Not all objects have a period annotation, they need annotations well to appear.

@bfhealy
Copy link
Collaborator

bfhealy commented Sep 1, 2022

It looks like this issue has been mostly addressed in Skyportal, since I can view folded light curves in the source dropdown. The default period (= 1 d) for sources without an uploaded period will ensure this panel is always displayed if photometry is available. Period annotations are also shown in the dropdown. Ashish's question about DR8 (SDSS or ZTF?) remains, though.

@mcoughlin
Copy link
Collaborator

@bfhealy I think we should either rename the issue or close this one and open another. It is challenging of course if one issue has multiple different things reported.

@bfhealy
Copy link
Collaborator

bfhealy commented Sep 1, 2022

I agree, I think it's best to close this one and open another. Should the new one be posted to Skyportal instead of here?

@mcoughlin
Copy link
Collaborator

@bfhealy agreed.

@bfhealy bfhealy closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants