-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add folded lightcurves to the 'group' page #59
Comments
@janvanroestel Do you mean the source table page? |
I see that the phased light curves are now seen on the group page. Thats is great (and very helpful). Also, can we add the period itself - may be on the x-label, or the top-label? (Is what is called DR8 the DR8 of SDSS or ZTF? That should be clarified in that figure's caption). |
@AshishMahabal Not all objects have a period annotation, they need annotations well to appear. |
It looks like this issue has been mostly addressed in Skyportal, since I can view folded light curves in the source dropdown. The default period (= 1 d) for sources without an uploaded period will ensure this panel is always displayed if photometry is available. Period annotations are also shown in the dropdown. Ashish's question about DR8 (SDSS or ZTF?) remains, though. |
@bfhealy I think we should either rename the issue or close this one and open another. It is challenging of course if one issue has multiple different things reported. |
I agree, I think it's best to close this one and open another. Should the new one be posted to Skyportal instead of here? |
@bfhealy agreed. |
We need to be able to see the folded lightcurve on the 'group' page, instead of clicking on the objects and having to open a new window. This needs to be done in skyportal.
The text was updated successfully, but these errors were encountered: