Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the ciou loss vs. computeciou #8

Open
ginobilinie opened this issue Jun 24, 2020 · 8 comments
Open

the ciou loss vs. computeciou #8

ginobilinie opened this issue Jun 24, 2020 · 8 comments

Comments

@ginobilinie
Copy link

Thanks for sharing the code.

I have noticed that in your other repositories (for example, https://github.com/Zzh-tju/DIoU-pytorch-detectron), you implement the computeciou function as the ciou loss, which is different from the implementation in this repository. I'm wondering why the implementation is different and which one do you suggest to use?

@ginobilinie
Copy link
Author

OR ciou is only for ssd/yolact and computeciou for faster-rcnn/mask-rcnn?

@Zzh-tju
Copy link
Owner

Zzh-tju commented Jun 24, 2020

The difference is due to the different variables feed in the function. You just choose them according to your basic model.

@ginobilinie
Copy link
Author

I see. Thanks.

@kelvinkoh0308
Copy link

Hi,
In compute_ciou function, you implemented as
with torch.no_grad():
S = 1 - iouk
alpha = v / (S + v)
But in ciou function, you implemented as
with torch.no_grad():
S = (iou>0.5).float()
alpha= S*v/(1-iou+v)
Can I know what is the difference between these two?

@kelvinkoh0308
Copy link

And also which one is suggested to follow

@Zzh-tju
Copy link
Owner

Zzh-tju commented Aug 5, 2020

@kelvinkoh0308 both are ok

@kelvinkoh0308
Copy link

@Zzh-tju thanks for your reply

@kelvinkoh0308
Copy link

@Zzh-tju can I know what is the reason that you add S = (iou>0.5).float() ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants