Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very tiny dog-leg road breaks #203

Open
dabreegster opened this issue Feb 17, 2023 · 2 comments
Open

Very tiny dog-leg road breaks #203

dabreegster opened this issue Feb 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@dabreegster
Copy link
Contributor

https://a-b-street.github.io/osm2streets/#20.35/51.47542/-2.53857
Screenshot from 2023-02-17 15-24-01
https://www.openstreetmap.org/node/60643708

This looks like a case where we should collapse the road, but the initial thing broke on one side?

@dabreegster dabreegster added the bug Something isn't working label Feb 17, 2023
@dabreegster
Copy link
Contributor Author

Few things go wrong here. The tiny road attached to the north end is a degenerate intersection. We initially fail to make geometry for that side due to

// If either road is too short, just fail outright. What else should we do?
.

We don't later try to collapse it as a degenerate intersection, because the road name and lane specs don't match. (Sidewalks tagged vs not.) If we force it anyway, the intersection geometry is OK, but actually it reveals lane polygons blow up when there's a sharp and small bend at the very end of the polyline:
Screenshot from 2023-02-21 11-11-56

If I forcibly mark the tiny road as internal_junction and collapse it, the result is better:
Screenshot from 2023-02-21 11-14-13

But how can we detect when this resolution would work? If I apply it every time the degenerate intersection geometry case finds a road too short, then some other tests degrade, like aurora sausage, where there are very tiny crosswalk ways:
Screenshot from 2023-02-21 11-16-25

Maybe in the short term, only applying this rule to driveable short degenerate roads could work...

@dabreegster
Copy link
Contributor Author

dabreegster commented Feb 21, 2023

If I force degenerate intersection geometry to work in more cases by reducing the required length, it doesn't break, but doesn't look good:
Screenshot from 2023-02-21 11-19-58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant