Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade source_gen dependency to ^0.5.0 #9

Closed
domesticmouse opened this issue Aug 25, 2016 · 4 comments
Closed

Please upgrade source_gen dependency to ^0.5.0 #9

domesticmouse opened this issue Aug 25, 2016 · 4 comments

Comments

@domesticmouse
Copy link

Hi Alexandre,

The out of date dependency of js_wrapping on source_gen 0.3.0 is blocking my app from upgrading to Angular2 2.0.0-beta.20. I forked and uplifted the dependency in js_wrapping myself, but I'm lost in the underlying source_gen API changes.

Halp?

@a14n
Copy link
Owner

a14n commented Aug 26, 2016

Similar to #8

Actually source_gen is only used to generate source files. So if you consume a lib that has been generated with js_wrapping you can simply add a dependency_overrides entry in your Angular app:

dependency_overrides:
  source_gen: ^0.5.0

@domesticmouse
Copy link
Author

Thanks, works nicely!

@zoechi
Copy link

zoechi commented Sep 9, 2016

Perhaps js_wrapping could be split into a package that contains the part that the generated code also needs and the generator itself so that a package containing generated code doesn't depend on the generator and its dependencies.

@a14n
Copy link
Owner

a14n commented Nov 16, 2016

Starting from 0.3.0 the package has been splitted in 2 parts (the dependency and the generator). There should not be conflict on source_gen dependency if you consume a package generated with js_wrapping (eg. google_maps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants