Attempt to give better error reporting in the UI. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires using the library branch `better-errors`. Currently, this just tries to parse "missing varible" messages from Tera. This is very hacky and brittle, and would be better done if Tera could report rendering errors more richly. Some other things that aren't great are: - We highlight the entire column, when we should try to pinpoint the specific row that caused the error. - Im not really sure what to do if the script uses a key that isn't in the config table. This is annoying to detect but could feasibly be done.
We now `await init()` at the very end of `index.js` to avoid blocking the rest of the file from running. This allows the page to be more useable at start up and lets things like the Config Table generate before Cohoard has loaded.
It's eggbug!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this just tries to parse "missing variable" messages from Tera.
This is very hacky and brittle, and would be better done if Tera could
report rendering errors more richly. Some other things that aren't great
are:
Must be merged with #27
Would complete one task in #9