Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit status of Pylint subprocess not checked #16

Open
anjsimmo opened this issue Apr 6, 2020 · 1 comment
Open

Exit status of Pylint subprocess not checked #16

anjsimmo opened this issue Apr 6, 2020 · 1 comment

Comments

@anjsimmo
Copy link
Contributor

anjsimmo commented Apr 6, 2020

task_analyse_pylint executes Pylint as a subprocess and checks stderr for errors. However, if Pylint fails in an unexpected way (e.g. the task is killed) the stderr may be empty, thus causing the script to incorrectly assume Pylint completed successfully.

We should check the process exit status as an additional safegaurd against the possibility of missing warnings (a threat to the internal validity of the study).

@anjsimmo anjsimmo changed the title Exit status of Pylint subprocesses not checked Exit status of Pylint subprocess not checked Apr 6, 2020
@anjsimmo
Copy link
Contributor Author

Additional details: In some cases, Pylint is printing warnings to stderr that can be safely ignored. It would be much better to check the return code of Pylint rather than attempting to use stderr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant